[PATCH] D78512: [llvm][NFC] Factor out inlining pipeline as a module pipeline.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 10:15:08 PDT 2020


mtrofin marked 2 inline comments as done.
mtrofin added inline comments.


================
Comment at: llvm/test/Other/new-pm-defaults.ll:136
+; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}>
+; CHECK-O-NEXT: Starting llvm::Module pass manager run.
 ; CHECK-O-NEXT: Running pass: ModuleToPostOrderCGSCCPassAdaptor<{{.*}}LazyCallGraph{{.*}}>
----------------
jdoerfert wrote:
> This is not strictly speaking NFC. You could pass the ModulePassManager to the `buildInlinerPipeline` though.
That wouldn't allow us to treat the output of buildInlinerPipeline as a pass.

Happy to remove the 'NFC'. So I learn - can structural changes to the pipeline account for any practically detectable functionality change (other than this here, which is observable by logs)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78512/new/

https://reviews.llvm.org/D78512





More information about the llvm-commits mailing list