[PATCH] D78538: [llvm][NFC][CallSite] Remove CallSite from DeadArgumentElimination

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 21 09:10:18 PDT 2020


mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp:567
     // If this use is anything other than a call site, the function is alive.
-    const Instruction *TheCall = CS.getInstruction();
-    if (!TheCall) {   // Not a direct call site?
+    if (!CB) { // Not a direct call site?
       MarkLive(F);
----------------
craig.topper wrote:
> I don't understand why this block exists. We already returned if it wasn't a callsite.
Nice catch! Indeed, 557 took care of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78538/new/

https://reviews.llvm.org/D78538





More information about the llvm-commits mailing list