[PATCH] D78556: [mlir] [linalg] Specify alignment during promotion.

Tue Apr 21 06:27:09 PDT 2020

ftynse added a comment.

Please provide a longer commit description (https://mlir.llvm.org/getting_started/Contributing/#commit-messages)

================
Comment at: mlir/test/Dialect/Linalg/transform-patterns.mlir:448
+
+func @aligned_promote_matmul(%arg0: memref<?x?xf32, offset: ?, strides: [?, 1]>,
+                             %arg1: memref<?x?xf32, offset: ?, strides: [?, 1]>,
----------------
I wonder if we could have a significantly simpler test here that only looks at promotion rather than replicating matmul every time. There seems to be a lot of things that are tested elsewhere and will lead to additional churn when the transformation is modified.

Could you maybe try linalg.fill instead?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78556/new/

https://reviews.llvm.org/D78556