[PATCH] D77652: [obj2yaml] - Fix the issue with dumping empty sections when dumping program headers.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:589
+## address space of a segment, but inside its file space. We do not include such sections
+## to a segment when they are at the edges of a segment, because this is usually a normal
+## case and it means they belong to a different segment.
----------------
to a segment -> in a segment

I think you can delete "usually" here too.


================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:590
+## to a segment when they are at the edges of a segment, because this is usually a normal
+## case and it means they belong to a different segment.
+# RUN: yaml2obj --docnum=7 %s -o %t7
----------------
it means -> it may mean


================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:614
+      - Section: .empty_end
+    VAddr: 0x1000
+Sections:
----------------
I missed that this segment had an address initially. I'd put it before the Sections list.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77652/new/

https://reviews.llvm.org/D77652