[PATCH] D78491: Avoid relying on address space zero default parameter in llvm/IR

[Dylan McKay via Phabricator via llvm-commits]

dylanmckay added a comment.

> should help targets such as AVR than use a non-zero program address space.

It definitely will - we have the exact same problems in terms of every call to `getUnqual` on a function pointer becomes a ISel error.

> I think making such bugs a compilation failure should be beneficial for everyone even if it means typing a few more characters to get a pointer type.

I agree, it's the only reasonable way to support AVR at a level on-par with other official backends, all of which do not place functions in nonzero address spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78491/new/

https://reviews.llvm.org/D78491