[PATCH] D78498: [mlir] [linalg] Only promote selected buffers.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransformPatterns.td:119
+class PromoteSelectedSubviewsLinalgOp<list<int> operands, string marker=""> :
+  NativeCodeCall<"promoteSelectedSubviewsLinalgOpAndSetMarker($_builder, op, {" #
+    StrJoinInt<operands>.result # "}, \"" # marker # "\")">;
----------------
Please wrap this at 80 characters, it seems to be edging over here.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/LinalgTransforms.cpp:345
+  toPromote.reserve(nBuffers);
+  for (int64_t i = 0; i < nBuffers; ++i)
+    toPromote.push_back(i);
----------------
nit: You could use std::iota here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78498/new/

https://reviews.llvm.org/D78498