[PATCH] D77714: Extended Liveness analysis to support nested regions.

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/IR/Region.h:114
+  /// Returns 'block' if 'block' lies in this region, or otherwise finds the
+  /// ancestor block of 'block' that lies in this region. Returns nullptr if
+  /// the latter fails.
----------------
nit: ancestor block -> ancestor

(There are a lot of 'block's in that sentence)


================
Comment at: mlir/lib/Analysis/Liveness.cpp:42-43
+        Block *ownerBlock = useOp->getBlock();
+        // Find an owner block in the current region.
+        // Note that a value does not escape this block if it
+        // is used in a nested region.
----------------
Can you reflow these comments to wrap at 80 characters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77714/new/

https://reviews.llvm.org/D77714