[PATCH] D78546: Enable bugprone-argument-comments check in llvm.

[Haojian Wu via Phabricator via llvm-commits]

hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

LLVM code style encourages this [1], this check can detect the missing cases
and provide an automatic fixit.

[1] https://llvm.org/docs/CodingStandards.html#comment-formatting


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78546

Files:
  .clang-tidy


Index: .clang-tidy
===================================================================
--- .clang-tidy
+++ .clang-tidy
@@ -1,4 +1,4 @@
-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming'
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming,bugprone-argument-comment'
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase
     value:           CamelCase
@@ -16,4 +16,11 @@
     value:           CamelCase
   - key:             readability-identifier-naming.IgnoreMainLikeFunctions
     value:           1
-
+  - key:             bugprone-argument-comment.CommentBoolLiterals
+    value:           1
+  - key:             bugprone-argument-comment.CommentIntegerLiterals
+    value:           1
+  - key:             bugprone-argument-comment.CommentFloatLiterals
+    value:           1
+  - key:             bugprone-argument-comment.CommentNullPtrs
+    value:           1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78546.258931.patch
Type: text/x-patch
Size: 1085 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200421/9f699a9c/attachment.bin>