[PATCH] D78474: [llvm-objcopy][MachO] Make --remove-section clean up dead symbols
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 21 02:07:51 PDT 2020
alexshap marked an inline comment as done.
alexshap added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/MachO/remove-section-dead-symbols.test:4
+
+# RUN: llvm-readobj --sections --symbols %t.copy | FileCheck %s
+
----------------
jhenderson wrote:
> jhenderson wrote:
> > alexshap wrote:
> > > jhenderson wrote:
> > > > What's the reason for dumping the sections here?
> > > we have removed one section ("C") - thus we'd like to verify that the list of sections is correct
> > > ["__text", "__data"]
> > I guess my question is more along the lines of "we test the section is removed elsewhere, so do we need to test here?" Happy either way, if you think there's additional value.
> > I guess my question is more along the lines of "we test the section is removed elsewhere, so do we need to test here?" Happy either way, if you think there's additional value.
>
> Just flagging this repsonse up in case you missed it. Do you think there's additional value in testing it here as well as in the regular --remove-section test?
I don't have any strong preferences regarding this, I've updated the test (removed those lines).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78474/new/
https://reviews.llvm.org/D78474
More information about the llvm-commits
mailing list