[PATCH] D76839: [lld-macho] Extend SyntheticSections to cover all segment load commands

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:85
+
+bool BindingSection::isNeeded() const { return in.got->isNeeded(); }
+
----------------
int3 wrote:
> smeenai wrote:
> > Any reason to have this one-liner not be part of the header?
> The declaration of `InStruct` appears at the end of the header file, so `in` isn't visible at `isNeeded()`'s declaration.
Sure, but we could move that order around :) (You'd just need a `struct GotSection;` forward declaration.)

I don't think it really matters though ... I doubt the cost of not inlining this in the writer would be significant (and LTO would be able to inline it regardless, if you really cared about perf).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76839/new/

https://reviews.llvm.org/D76839