[PATCH] D76252: [lld-macho] Add basic support for linking against dylibs

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 22:45:54 PDT 2020


int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:91-92
+  std::vector<StringRef> ret;
+  if (!args.hasArg(OPT_Z))
+    ret = {"/usr/lib", "/usr/local/lib"};
+  for (StringRef s : args::getStrings(args, OPT_L))
----------------
smeenai wrote:
> I believe these should actually be placed on the search path *after* any user-specified `-L` directories. At least that's what ld64 appears to do, based on the output from its `-v` option.
Oh good catch. I'll make our `-v` option emit that too so we can test for it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76252/new/

https://reviews.llvm.org/D76252





More information about the llvm-commits mailing list