[PATCH] D76839: [lld-macho] Extend SyntheticSections to cover all segment load commands

[Jez Ng via Phabricator via llvm-commits]

int3 marked 4 inline comments as done.
int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:85
+
+bool BindingSection::isNeeded() const { return in.got->isNeeded(); }
+
----------------
smeenai wrote:
> Any reason to have this one-liner not be part of the header?
The declaration of `InStruct` appears at the end of the header file, so `in` isn't visible at `isNeeded()`'s declaration.


================
Comment at: lld/MachO/SyntheticSections.h:97
+// Stores the strings referenced by the symbol table.
+class StringPoolSection : public InputSection {
+public:
----------------
smeenai wrote:
> I'd prefer StringTable over StringPool, since string table is the standard terminology used in the Mach-O reference.
D'oh, this entire section should be added in the symtab diff. Rebasing headaches 😅

Will move it over and rename


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76839/new/

https://reviews.llvm.org/D76839