[PATCH] D78174: [VE] Add alternative names to registers

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 20:36:35 PDT 2020


kaz7 marked an inline comment as done.
kaz7 added inline comments.


================
Comment at: llvm/lib/Target/VE/MCTargetDesc/VEInstPrinter.cpp:41
+  unsigned AltIdx = VE::AsmName;
+  OS << '%' << StringRef(getRegisterName(RegNo, AltIdx)).lower();
 }
----------------
arsenm wrote:
> You should be able to directly use the output of getRegisterName without the lower now?
That's true.  I haven't noticed it.  Thank you for very useful comments to reduce computation time.  I really appreciate it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78174/new/

https://reviews.llvm.org/D78174





More information about the llvm-commits mailing list