[PATCH] D76926: [Dexter] Add Debugger Controller To Dexter

[Tobias Bosch via Phabricator via llvm-commits]

tbosch added a comment.

Hello, I believe this broke the test "clang-opt-bisect" (ran at ee12edcb76423c78b55cdddae2edfe45cbb2ccd6 <https://reviews.llvm.org/rGee12edcb76423c78b55cdddae2edfe45cbb2ccd6>):

  ******************** TEST 'debuginfo-tests :: dexter/feature_tests/subtools/clang-opt-bisect/clang-opt-bisect.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 6';   true
  : 'RUN: at line 7';   "/usr/bin/python" "/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/dexter.py" clang-opt-bisect --debugger 'lldb' --builder 'clang'      --cflags "-O0 -g" -- /usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/feature_tests/subtools/clang-opt-bisect/clang-opt-bisect.cpp      | /usr/local/google/home/tbosch/llvm-project/build/bin/FileCheck /usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/feature_tests/subtools/clang-opt-bisect/clang-opt-bisect.cpp
  --
  Exit Code: 2
  
  Command Output (stderr):
  --
  
  
  ****************************************
  ****************************************
  ****************************************
  **                                    **
  ** This is a bug in DExTer.           **
  **                                    **
  **                  Please report it. **
  **                                    **
  ****************************************
  ****************************************
  ****************************************
  
  system:
  linux
  
  version:
  DExTer 1.0.0 [master ee12edcb76423c78b55cdddae2edfe45cbb2ccd6] (git at github.com:tbosch/llvm-project.git)
    using Python 3.7.6 (default, Dec 19 2019, 09:25:23)
  [GCC 9.2.1 20191109]
  
  args:
  ['/usr/bin/python', '/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/dexter.py', 'clang-opt-bisect', '--debugger', 'lldb', '--builder', 'clang', '--cflags', '-O0 -g', '--', '/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/feature_tests/subtools/clang-opt-bisect/clang-opt-bisect.cpp']
  
  Traceback (most recent call last):
    File "/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/dexter.py", line 15, in <module>
      return_code = main()
    File "/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/dex/tools/Main.py", line 193, in main
      return tool_main(context, module.Tool(context), args)
    File "/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/dex/tools/Main.py", line 162, in tool_main
      return_code = tool.go()
    File "/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/dex/tools/TestToolBase.py", line 122, in go
      self._run_test(self._get_test_name(options.test_path))
    File "/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/dex/tools/clang_opt_bisect/Tool.py", line 141, in _run_test
      self.context, debugger_controller)
    File "/usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/dex/debugger/Debuggers.py", line 140, in run_debugger_subprocess
      dir=working_dir_path, delete=False, mode='wb') as fp:
    File "/usr/lib/python3.7/tempfile.py", line 686, in NamedTemporaryFile
      (fd, name) = _mkstemp_inner(dir, prefix, suffix, flags, output_type)
    File "/usr/lib/python3.7/tempfile.py", line 395, in _mkstemp_inner
      file = _os.path.join(dir, pre + name + suf)
    File "/usr/lib/python3.7/posixpath.py", line 80, in join
      a = os.fspath(a)
  TypeError: expected str, bytes or os.PathLike object, not DefaultController
  FileCheck error: '<stdin>' is empty.
  FileCheck command line:  /usr/local/google/home/tbosch/llvm-project/build/bin/FileCheck /usr/local/google/home/tbosch/llvm-project/debuginfo-tests/dexter/feature_tests/subtools/clang-opt-bisect/clang-opt-bisect.cpp

P.S.: You might have received this comment 2x, I am new to phrabricator...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76926/new/

https://reviews.llvm.org/D76926