[PATCH] D78519: Update mlir for CreateShuffleVector with unsigned deprecation

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 16:18:30 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG2d9a02a63a10: Update LLVMOps for CreateShuffleVector deprecation and rework creation string. (authored by echristo).

Changed prior to commit:
  https://reviews.llvm.org/D78519?vs=258848&id=258863#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78519/new/

https://reviews.llvm.org/D78519

Files:
  mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td


Index: mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
===================================================================
--- mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
+++ mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
@@ -410,9 +410,12 @@
 }
 def LLVM_ShuffleVectorOp
     : LLVM_OneResultOp<"shufflevector", [NoSideEffect]>,
-      Arguments<(ins LLVM_Type:$v1, LLVM_Type:$v2, ArrayAttr:$mask)>,
-      LLVM_Builder<
-      "$res = builder.CreateShuffleVector($v1, $v2, extractPosition($mask));"> {
+      Arguments<(ins LLVM_Type:$v1, LLVM_Type:$v2, ArrayAttr:$mask)> {
+  string llvmBuilder = [{
+      SmallVector<unsigned, 4> position = extractPosition($mask);
+      SmallVector<int, 4> mask(position.begin(), position.end());
+      $res = builder.CreateShuffleVector($v1, $v2, mask);
+  }];
   let builders = [OpBuilder<
     "Builder *b, OperationState &result, Value v1, Value v2, "
     "ArrayAttr mask, ArrayRef<NamedAttribute> attrs = {}">];


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78519.258863.patch
Type: text/x-patch
Size: 952 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200420/f792d8ec/attachment.bin>


More information about the llvm-commits mailing list