[PATCH] D78518: # Folder for division by one.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 16:18:16 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:1725
+      return lhs();
+  } // Assumes all tensors of all ones are splats.
+
----------------
This comment looks weirdly placed, can you move it to a more appropriate location?


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:2261
+      return lhs();
+  } // Assumes all tensors of all ones are splats.
+
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78518/new/

https://reviews.llvm.org/D78518





More information about the llvm-commits mailing list