[PATCH] D78522: [mlir][Symbol] Change Symbol from a Trait into an OpInterface.

[River Riddle via Phabricator via llvm-commits]

rriddle created this revision.
rriddle added a reviewer: mehdi_amini.
Herald added subscribers: llvm-commits, frgossen, grosul1, bader, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, jpienaar, eraman, mgorny.
Herald added a reviewer: mravishankar.
Herald added a reviewer: antiagainst.
Herald added a reviewer: herhut.
Herald added a reviewer: antiagainst.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.

This provides a much cleaner interface into Symbols, and allows for users to start injecting op-specific information. For example, derived op can now inject when a symbol can be discarded if use_empty. This would let us drop unused external functions, which generally have public visibility.

Depends On D78447 <https://reviews.llvm.org/D78447>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78522

Files:
  flang/include/flang/Optimizer/Dialect/FIROps.td
  mlir/include/mlir/Dialect/GPU/GPUOps.td
  mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
  mlir/include/mlir/Dialect/SPIRV/SPIRVStructureOps.td
  mlir/include/mlir/IR/CMakeLists.txt
  mlir/include/mlir/IR/Function.h
  mlir/include/mlir/IR/Module.h
  mlir/include/mlir/IR/OpBase.td
  mlir/include/mlir/IR/OpDefinition.h
  mlir/include/mlir/IR/SymbolInterfaces.td
  mlir/include/mlir/IR/SymbolTable.h
  mlir/include/mlir/TableGen/OpInterfaces.h
  mlir/lib/IR/CMakeLists.txt
  mlir/lib/IR/SymbolTable.cpp
  mlir/lib/TableGen/OpInterfaces.cpp
  mlir/lib/Transforms/Inliner.cpp
  mlir/lib/Transforms/SymbolDCE.cpp
  mlir/test/lib/Dialect/Test/TestOps.td
  mlir/test/lib/IR/TestSymbolUses.cpp
  mlir/tools/mlir-tblgen/OpInterfacesGen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78522.258858.patch
Type: text/x-patch
Size: 27052 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200420/9a57f10e/attachment-0001.bin>