[PATCH] D78415: Fix inlining multi-block callees with type conversion.

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.

Can you remove the explicit vector materialization here now?
https://github.com/llvm/llvm-project/blob/31282d399b79526303ae4b5d1f73ace8a40c6587/mlir/test/lib/Transforms/TestInlining.cpp#L48



================
Comment at: mlir/include/mlir/Transforms/InliningUtils.h:18
 #include "mlir/IR/Location.h"
+#include "mlir/IR/OperationSupport.h"
 #include "mlir/IR/Region.h"
----------------
Can you use forward declarations instead?


================
Comment at: mlir/lib/Transforms/Inliner.cpp:24
 #include "llvm/Support/Debug.h"
+#include "llvm/Support/DebugCounter.h"
 #include "llvm/Support/Parallel.h"
----------------
This is now unused?


================
Comment at: mlir/lib/Transforms/Inliner.cpp:29
 
+using llvm::DebugCounter;
 using namespace mlir;
----------------
These are now unused?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78415/new/

https://reviews.llvm.org/D78415