[PATCH] D78032: [llvm-objdump] Default to the "apple-latest" mcpu when disassembling arm64 Mach-O binaries

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 15:12:44 PDT 2020


lhames added a comment.

I would prefer to keep this change in the tool for now (as this patch does).

For disassembly purposes it makes sense to assume the newest CPU in case the object uses instructions from it. As a MachOObject file client on the other hand I would have expected getArchTriple to be conservative (i.e. "this object uses / requires the CPU specified"). I'm open to changing / reinterpreting getArchTriple's behavior, but I think that's a separate discussion from this patch and shouldn't block this going in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78032/new/

https://reviews.llvm.org/D78032





More information about the llvm-commits mailing list