[PATCH] D68408: [InstCombine] Negator - sink sinkable negations

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 14:38:43 PDT 2020


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp:2005
+  return Cleanup();
 }
 
----------------
xbolva00 wrote:
> Just wondering if we could use some better name for this lambda than “cleanup”.
I couldn't come up with a better one, any suggestions?
`TryToNarrowDeduceFlags()`?
This is where `goto` might make sense, but somehow i don't want to use it..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68408/new/

https://reviews.llvm.org/D68408





More information about the llvm-commits mailing list