[PATCH] D78130: [SVE] Fixup calls to VectorType::getNumElements() in IR

Mon Apr 20 14:38:40 PDT 2020

ctetreau added a comment.

In D78130#1993179 <https://reviews.llvm.org/D78130#1993179>, @sdesmalen wrote:

> Hi @ctetreau , @david-arm started looking through our downstream code-base to pull out some patches where we've fixed cases like the ones in this patch and for which we may already have tests.
>  Since there's likely to be overlap with this patch, are there any cases you've already got tests for, or are actively working on? If you have any other suggestions on how to share the effort, just let us know!

I've not yet started writing tests. I've completed the refactor on my machine. I'm doing a cleanup pass now, and plan to start pushing the patches up to phabricator soon. After all the patches are up and reviewers added, I planned to evaluate what changes need tests, and what changes aren't actually worth doing.

Once that's done and the list compiled, I was going to work on getting the tests written.

I'd also like to mention that the changes in this patch are pretty representative of the changes I'm making in other modules.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78130/new/

https://reviews.llvm.org/D78130