[PATCH] D68408: [InstCombine] Negator - sink sinkable negations

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a reviewer: xbolva00.
spatel added a comment.
This revision is now accepted and ready to land.

Given that we have compile-time data now, LGTM.
The implementation goes beyond my normal casual C++ usage (eg, I'd never seen 'zip' before), so if someone else can take a 2nd/final look too, that would be great.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp:133
+
+  // ZZZ
+  if (!V->hasOneUse() && !IsTrulyNegation)
----------------
Remove/update comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68408/new/

https://reviews.llvm.org/D68408