[PATCH] D78361: [yaml2obj] - Verify that sections are sorted by their file offsets when creating segments.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D78361#1990346 <https://reviews.llvm.org/D78361#1990346>, @grimar wrote:

> In D78361#1988960 <https://reviews.llvm.org/D78361#1988960>, @MaskRay wrote:
>
> > Can the tool sort program headers by p_offset so that reordered user input can be accepted? It may sometimes be useful to check how other tools behave with reordered input. This patch is dropping this feature.
>
>
>
>
>   This patch fixed issues in 5 of test cases, I believe they did not expect to have reordered sections. This is what is really useful.
>   
>
> > It may sometimes be useful to check how other tools behave with reordered input.
>
> I am not sure what do you mean, could you elaborate? Are you going to use YAMLs as inputs for another tools? Which tools? Are them a part of LLVM? Do we have any test cases?


Ah, I misread the patch. The check does not prevent any feature.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78361/new/

https://reviews.llvm.org/D78361