[PATCH] D78397: [mlir][Transforms] Add pass to perform sparse conditional constant propagation

[River Riddle via Phabricator via llvm-commits]

rriddle marked 3 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/SCCP.cpp:156
+
+  /// Mark the edge between 'from' and 'to' as executable.
+  void markEdgeExecutable(Block *from, Block *to);
----------------
bondhugula wrote:
> rriddle wrote:
> > bondhugula wrote:
> > > Nit: do either backticks and regular single quotes work for parameters in doc comments?
> > I'm not sure as we don't generate doxygen ATM for me to look at. The codebase is fairly inconsistent to either, but changed all within this file to consistently use ''. We should figure that out though, and standardize to using one.
> The doxygen is actually generated - it's here. https://mlir.llvm.org/doxygen/
Oh, nice.


================
Comment at: mlir/lib/Transforms/SCCP.cpp:308
+
+  value.replaceAllUsesWith(constant);
+  return success();
----------------
bondhugula wrote:
> If the value is an op result, do you want to / can you erase this op? You already have a pre inc iterator at its call site.
If you look at Line 281 we erase the op if it is valid and all of the results were replaced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78397/new/

https://reviews.llvm.org/D78397