[PATCH] D78438: [ELF] Temporarily delete "TLS attribute mismatch" diagnostics

Mon Apr 20 11:21:32 PDT 2020

MaskRay added a comment.

In D78438#1992809 <https://reviews.llvm.org/D78438#1992809>, @psmith wrote:

> Thanks for the update. If the gABI is going in that direction (let's hope Cary can get the new version in a place where it can be updated fairly soon) then I'm happy about that part. I think that if we are able to keep the error where it makes sense such as in scanRelocs then I'm happy to remove it from where it is currently, which I agree is not ideally placed to avoid false positives.
>
> I think the link to the gABI is https://groups.google.com/forum/#!topic/generic-abi/dJ4_Y78aQ2M I think the m/WKggp9fKCgAJ part is specific to your login.

Sorry, I just edited my comment (after re-reading `TLS relocations referencing section symbols`). The new content is very different from when I made the comment initially.

If we are going to retain the "TLS mismatch" diagnostics in Symbols.h, we need to preclude `STT_TLS, STT_SECTION` (reasonable symbols types from regular object files), STT_NOTYPE (from bitcode module-level inline assembly).

If we are going to move the "TLS mismatch" diagnostics to scanRelocs. We need to refactor `handleTlsRelocations` (which requires a considerable amount of work), we may need to split some RelExpr members (`R_GOT_PC` -> non-TLS / TLS). We will hit the the limit of 64 RelExpr members. We can have location information for https://bugs.llvm.org/show_bug.cgi?id=36049

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78438/new/

https://reviews.llvm.org/D78438