[PATCH] D78503: RFC: [ValueTracking] Let analyses assume a value cannot be partially poison

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:568
+  /// If I raises immediate UB (e.g. load poison), propagatesPoison returns
+  /// false.
+  bool propagatesPoison(const Instruction *I);
----------------
This doesn't seem to line up with the implementation, e.g. division ops return true for propagatesPoison.

I'm also not sure why we would not want to return true for immediate UB. It's a stronger condition, but it should always be fine to relax immediate UB into returning poison.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78503/new/

https://reviews.llvm.org/D78503