[PATCH] D78356: [flang] Use a better definition for ATTRIBUTE_UNUSED

Mon Apr 20 09:43:57 PDT 2020

aaron.ballman added a comment.

In D78356#1992256 <https://reviews.llvm.org/D78356#1992256>, @DavidTruby wrote:

> Sorry I probably wasn't very clear in what I was trying to say; I completely agree with you! My preference is to go for the attribute directly since it's guaranteed to at least parse in C++17 and I think every compiler we support implements the meaning as well.
>  If we decide not to do that my second preference is also to go for the existing LLVM_ATTRIBUTE_UNUSED.

Ah, okay, thank you for clarifying.

> However, I'm still in favour of merging this patch, as it is a quick fix for compilers that don't support the attribute we're trying to use at the moment. Moving over to using [[maybe_unused]] directly requires a lot more code modifications (I imagine, I don't actually know how many times ATTRIBUTE_UNUSED is used).

If this is for fixing a broken build then I'm all for landing it in this form right now and handling the churn later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78356/new/

https://reviews.llvm.org/D78356