[PATCH] D78352: [MLIR] Add GenericAtomicRMWOp.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:502
+    that represents the value stored in `memref[indices]` before the write is
+    performed.
+
----------------
We should mention that no side effecting operation is allowed in the region.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:536
+      return OpBuilder(&block, block.end());
+    }
+    // The value stored in memref[ivs].
----------------
This is the kind of method I expect provided by a Traits otherwise we're losing consistency across all operations with regions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78352/new/

https://reviews.llvm.org/D78352