[PATCH] D78044: [mlir][ods] Update doc regarding attribute definitions

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked 2 inline comments as done.
antiagainst added inline comments.


================
Comment at: mlir/docs/OpDefinitions.md:1040
+
+*   `DefaultValuedAttr`: decorates an attribute with a default value. See
+    [attributes with default values](#attributes-with-default-values) for
----------------
jpienaar wrote:
> Nit: but with these it seems we are duplicating ourselves, how about just
> 
> * `DefaultValueAttr`: specifies the [default value of an attribute](...).
> ...
> 
> folks can see the link and click if they want to find out more (meaning, I see a link as implicitly meaning "go here to find more info" and so don't need to spell it out).
Good point. Revised. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78044/new/

https://reviews.llvm.org/D78044