[PATCH] D78389: [ELF] Keep local symbols when both --emit-relocs and --discard-all are specified

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/emit-relocs-discard-locals.s:7
+# RUN: ld.lld --emit-relocs --discard-locals %t.o -o %tlocal
+# RUN: llvm-nm %tlocal | FileCheck --check-prefixes=NM,NM_NOGC %s
+# RUN: llvm-readobj -r %tlocal | FileCheck --check-prefix=REL %s
----------------
grimar wrote:
> `NM_NOGC` -> `NM-NOGC` (we don't use underbars in tests I think)
I've seen underscores in a few places. Thinking more, underscores may not be bad because it does not conflict with `-NOT` `-DAG` ... or possible future extensions..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78389/new/

https://reviews.llvm.org/D78389