[PATCH] D78327: [mlir][Linalg] Create a named batch_matmul op and pipe it through.

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgTraits.h:351
+template <typename ConcreteType>
+class NamedStructuredOpTraits
+    : public OpTrait::TraitBase<ConcreteType, NamedStructuredOpTraits> {
----------------
Nit: why plural "Traits" ?


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgTraits.h:356
+  llvm::Optional<SmallVector<AffineMap, 8>> referenceIndexingMaps();
+  std::function<void(OpBuilder &, Location, ArrayRef<Value>)>
+  emitScalarImplementation();
----------------
Nit: consider adding a short doc and/or vertical whitespace around declarations


================
Comment at: mlir/include/mlir/Dialect/Linalg/Transforms/CMakeLists.txt:6
+
+# Including Linalg in TableGen requires to depends on generated files
+add_dependencies(MLIRLinalgTransformPatternsIncGen LinalgOdsGen)
----------------
Nit typo: depend


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78327/new/

https://reviews.llvm.org/D78327