[PATCH] D78301: [ARM][MC][Thumb] Revert relocation for some pc-relative fixups.
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 20 06:25:28 PDT 2020
psmith added a comment.
In D78301#1992076 <https://reviews.llvm.org/D78301#1992076>, @psmith wrote:
> In D78301#1992038 <https://reviews.llvm.org/D78301#1992038>, @thakis wrote:
>
> > This broke check-lld everywhere, e.g. http://lab.llvm.org:8011/builders/lld-x86_64-win/builds/71/steps/test-check-all/logs/FAIL%3A%20lld%3A%3Aarm-thumb-undefined-weak.s or http://45.33.8.238/linux/15676/step_11.txt
> >
> > Please take a look, and revert while you investigate if it's not an easy fix.
>
>
> If you can give me a an hour or two I can fix, am away from computer at moment. The LLD test will need the adr and ldr instructions replaced with .inst and .reloc I thought I'd done all of these in arm-thumb-adr.s and arm-thumb-ldrlit.s but it looks like I missed this one.
Committed fix to LLD tests under 61bccda9d9d920c72f49025f11e8601daeb096ec <https://reviews.llvm.org/rG61bccda9d9d920c72f49025f11e8601daeb096ec> and checked it worked with this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78301/new/
https://reviews.llvm.org/D78301
More information about the llvm-commits
mailing list