[PATCH] D78356: [flang] Use a better definition for ATTRIBUTE_UNUSED

Mon Apr 20 04:16:04 PDT 2020

DavidTruby added a comment.

@aaron.ballman tried to give a review here but couldn't add himself so he sent this review by email, which I will include here for completeness:

> Is there a reason to
>  not use LLVM_ATTRIBUTE_UNUSED from Compiler.h? (Sorry if this is a
>  dumb drive-by question.)

In answer to the question (which isn't a dumb one at all!) I would prefer LLVM_ATTRIBUTE_UNUSED to our custom one; however since Flang requires C++17 (unlike most of LLVM) I think we should just use the standard attribute everywhere as it's guaranteed to be available on any C++17 compatible compiler.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78356/new/

https://reviews.llvm.org/D78356