[PATCH] D78422: [LLD][ELF][ARM] Fix ARM Exidx order for non monotonic section order

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 02:39:10 PDT 2020


grimar added a comment.

2 nits, otherwise LG.



================
Comment at: lld/ELF/Writer.cpp:1621
+  // .ARM.exidx does not require precise addresses, but it does require the
+  // relative address of OutputSections.
+  for (Partition &part : partitions)
----------------
I'd expand this comment a bit.
"relative address of OutputSections, because ... "


================
Comment at: lld/test/ELF/arm-exidx-script-order.s:20
+// 0x80000010 f0010000 10849880 ec010000 01000000
+ .text
+ .global _start
----------------
Missing an empty line before `.text`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78422/new/

https://reviews.llvm.org/D78422





More information about the llvm-commits mailing list