[PATCH] D78287: [VPlan] Clean up tryToCreate(Widen)Recipe. (NFC)

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 4 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7085
+
+    return new VPWidenPHIRecipe(Phi);
   }
----------------
Ayal wrote:
> It would be clearer to further refactor the handling of Phi's into
> 
> ```
>   if (Phi->getParent() != OrigLoop->getHeader())
>     return tryToBlend(Phi, Plan); // Rename to createBlendRecipe()?
>   if (Recipe = tryToOptimizeInductionPHI(Phi))
>     return Recipe;
>   return new VPWidenPHIRecipe(Phi); // Rename to VPWidenHeaderPHIRecipe()?
> ```
Thanks, I'll include the changes in the commit. Renaming could be done as follow-up, together with the suggestion re BlendRecipe above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78287/new/

https://reviews.llvm.org/D78287