[PATCH] D78339: [llvm-objcopy][MachO] Copy LC_ENCRYPT_INFO/LC_ENCRYPT_INFO_64 load commands
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 20 01:34:35 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with nit.
================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp:321
+ // segment of executables isn't supported anyway (e.g. data in code entries
+ // are not recalculated), moreover, in general
+ // LC_ENCRYPT_INFO/LC_ENCRYPTION_INFO_64 are nontrivial to update because
----------------
Nit: ", moreover, " -> ". Moreover, "
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78339/new/
https://reviews.llvm.org/D78339
More information about the llvm-commits
mailing list