[PATCH] D77805: [obj2yaml] - Teach obj2yaml to dump SHT_NOBITS sections when dumping program headers.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 20 01:02:31 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM with grammar and typo fixes.
================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:493
+ Flags: [ SHF_WRITE, SHF_ALLOC ]
+## Use an arbitraty address and size.
+ Address: 0x1000
----------------
arbitraty -> arbitrary
================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:499
+ Flags: [ SHF_WRITE, SHF_ALLOC ]
+## Use the size which is larger than the file size.
+ Size: 0x00000000FFFFFFFF
----------------
the size which -> a size that
================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:504
+ Flags: [ SHF_WRITE, SHF_ALLOC ]
+## Use an arbitraty size.
+ Size: 0x1
----------------
arbitraty -> arbitrary
================
Comment at: llvm/test/tools/obj2yaml/program-headers.yaml:517
+ Flags: [ SHF_WRITE, SHF_ALLOC ]
+## Use an arbitraty size that is different from the size of
+## the previous section.
----------------
arbitraty -> arbitrary
different from -> different to
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77805/new/
https://reviews.llvm.org/D77805
More information about the llvm-commits
mailing list