[PATCH] D78438: [ELF] Delete "TLS attribute mismatch" diagnostics

[Peter Smith via Phabricator via llvm-commits]

psmith added a comment.

I agree that the diagnostic where it currently lives is not ideal. I'm not comfortable with removing it completely as over the years I've seen several compiler bugs detected before release by this type of error; TLS variables are almost always accessed via C-code so we don't tend to see mistakes unless there is a bug. Is there another place that we can put this warning and get most of the benefit? For example if we added the check in scanRelocs the symbol combination would have completed so if there was a non-TLS symbol reference (via bitcode or assembly) that was replaced by a TLS definition we would accept that. However if the definition were non-TLS we would.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78438/new/

https://reviews.llvm.org/D78438