[PATCH] D78470: [CallSite removal][SCCP] Use CallBase instead of CallSite. NFC

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 19 23:57:45 PDT 2020


mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:1134
 
-void SCCPSolver::visitCallSite(CallSite CS) {
-  handleCallResult(CS);
-  handleCallArguments(CS);
+void SCCPSolver::visitCallBase(CallBase &I) {
+  handleCallResult(I);
----------------
craig.topper wrote:
> mtrofin wrote:
> > Nit: here and below, CallBase &CB?
> I was just trying to be consistent with the other visitor functions in the file. But I can change it.
Ah... I see, looks like some cases use just generic "I", some use acronyms (visitCatchSwitch for example). It's a nit anyway, the patch is good to land.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78470/new/

https://reviews.llvm.org/D78470





More information about the llvm-commits mailing list