[PATCH] D77788: [PowerPC][Future] Enable Tail Calls for PC Relative Code

[Anil Mahmud via Phabricator via llvm-commits]

anil9 added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1549
     // 5) This function uses inline asm. We mark R2 as reserved if the function
     //    has inline asm so we have to assume that it may be used.
+    if (MF->getFrameInfo().hasCalls() || MF->getFrameInfo().hasTailCall() ||
----------------
nit :  asm so we have ->  asm as we have


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:1694
+  // since we can tail call external functions with PC-Rel (i.e. don't need to
+  // worry about different TOC pointers). Some of the external funcions will
+  // be MO_GlobalAddress while others (like memcpy for example) are going to
----------------
nits:   (i.e don't) -> (i.e we don't) 
Some of the external funcions -> functions.
(like memcpy for example) -> like memcpy for example,


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:4791
+  // All variants of 64-bit ELF ABIs without PC-Relative addressing
+  // require that the caller and callee share the same TOC for
+  // TCO/SCO. If the caller and callee potentially have different TOC bases
----------------
nit: It seems you need to format these comments, they seem to be wrapping around even before reaching 80 chars.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77788/new/

https://reviews.llvm.org/D77788