[PATCH] D78419: [X86][MC][NFC] Reduce the parameters of functions in X86MCCodeEmitter(Part III)
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 19 15:29:48 PDT 2020
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
> tell() returns a uint64_t and since you can't know how the encoder is being called, I think you have to assume you might have more than 2^32 bytes in the stream already.
You have addressed @craig.topper's comment but please remember to mark it as done (click `done` before `arc diff`)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78419/new/
https://reviews.llvm.org/D78419
More information about the llvm-commits
mailing list