[llvm] a2eb55d - [InstSimplify] add tests for logic+icmp folds for nullptr; NFC
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 19 07:43:08 PDT 2020
Author: Sanjay Patel
Date: 2020-04-19T10:42:08-04:00
New Revision: a2eb55de998f84cef9fe84328d4d3f9db72b69e3
URL: https://github.com/llvm/llvm-project/commit/a2eb55de998f84cef9fe84328d4d3f9db72b69e3
DIFF: https://github.com/llvm/llvm-project/commit/a2eb55de998f84cef9fe84328d4d3f9db72b69e3.diff
LOG: [InstSimplify] add tests for logic+icmp folds for nullptr; NFC
See discussion in D78430.
Added:
llvm/test/Transforms/InstSimplify/and-or-icmp-nullptr.ll
Modified:
Removed:
################################################################################
diff --git a/llvm/test/Transforms/InstSimplify/and-or-icmp-nullptr.ll b/llvm/test/Transforms/InstSimplify/and-or-icmp-nullptr.ll
new file mode 100644
index 000000000000..0d88e97f6bfa
--- /dev/null
+++ b/llvm/test/Transforms/InstSimplify/and-or-icmp-nullptr.ll
@@ -0,0 +1,303 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -instsimplify -S | FileCheck %s
+
+; This is a specialization of generic folds for min/max values targeted to the
+; 'null' ptr constant.
+; Related tests for non-pointer types should be included in another file.
+
+; There are 6 basic patterns (or 3 with DeMorganized equivalent) with
+; 2 (commute logic op) *
+; 2 (swap compare operands) *
+; variations for a total of 24 tests.
+
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;
+; (X == null) && (X > Y) --> false
+;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+
+define i1 @ugt_and_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_and_min(
+; CHECK-NEXT: ret i1 false
+;
+ %cmp = icmp ugt i8* %x, %y
+ %cmpeq = icmp eq i8* %x, null
+ %r = and i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ugt_and_min_commute(<2 x i8>* %x, <2 x i8>* %y) {
+; CHECK-LABEL: @ugt_and_min_commute(
+; CHECK-NEXT: ret i1 false
+;
+ %cmp = icmp ugt <2 x i8>* %x, %y
+ %cmpeq = icmp eq <2 x i8>* %x, null
+ %r = and i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+define i1 @ugt_swap_and_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_swap_and_min(
+; CHECK-NEXT: ret i1 false
+;
+ %cmp = icmp ult i8* %y, %x
+ %cmpeq = icmp eq i8* %x, null
+ %r = and i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ugt_swap_and_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_swap_and_min_commute(
+; CHECK-NEXT: ret i1 false
+;
+ %cmp = icmp ult i8* %y, %x
+ %cmpeq = icmp eq i8* %x, null
+ %r = and i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;
+; (X != null) || (X <= Y) --> true
+;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+
+define i1 @ule_or_not_min(i427* %x, i427* %y) {
+; CHECK-LABEL: @ule_or_not_min(
+; CHECK-NEXT: ret i1 true
+;
+ %cmp = icmp ule i427* %x, %y
+ %cmpeq = icmp ne i427* %x, null
+ %r = or i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ule_or_not_min_commute(<3 x i9>* %x, <3 x i9>* %y) {
+; CHECK-LABEL: @ule_or_not_min_commute(
+; CHECK-NEXT: ret i1 true
+;
+ %cmp = icmp ule <3 x i9>* %x, %y
+ %cmpeq = icmp ne <3 x i9>* %x, null
+ %r = or i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+define i1 @ule_swap_or_not_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_swap_or_not_min(
+; CHECK-NEXT: ret i1 true
+;
+ %cmp = icmp uge i8* %y, %x
+ %cmpeq = icmp ne i8* %x, null
+ %r = or i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ule_swap_or_not_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_swap_or_not_min_commute(
+; CHECK-NEXT: ret i1 true
+;
+ %cmp = icmp uge i8* %y, %x
+ %cmpeq = icmp ne i8* %x, null
+ %r = or i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;
+; (X == null) && (X <= Y) --> X == null
+;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+
+define i1 @ule_and_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_and_min(
+; CHECK-NEXT: [[CMPEQ:%.*]] = icmp eq i8* [[X:%.*]], null
+; CHECK-NEXT: ret i1 [[CMPEQ]]
+;
+ %cmp = icmp ule i8* %x, %y
+ %cmpeq = icmp eq i8* %x, null
+ %r = and i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ule_and_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_and_min_commute(
+; CHECK-NEXT: [[CMPEQ:%.*]] = icmp eq i8* [[X:%.*]], null
+; CHECK-NEXT: ret i1 [[CMPEQ]]
+;
+ %cmp = icmp ule i8* %x, %y
+ %cmpeq = icmp eq i8* %x, null
+ %r = and i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+define i1 @ule_swap_and_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_swap_and_min(
+; CHECK-NEXT: [[CMPEQ:%.*]] = icmp eq i8* [[X:%.*]], null
+; CHECK-NEXT: ret i1 [[CMPEQ]]
+;
+ %cmp = icmp uge i8* %y, %x
+ %cmpeq = icmp eq i8* %x, null
+ %r = and i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ule_swap_and_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_swap_and_min_commute(
+; CHECK-NEXT: [[CMPEQ:%.*]] = icmp eq i8* [[X:%.*]], null
+; CHECK-NEXT: ret i1 [[CMPEQ]]
+;
+ %cmp = icmp uge i8* %y, %x
+ %cmpeq = icmp eq i8* %x, null
+ %r = and i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;
+; (X == null) || (X <= Y) --> X <= Y
+;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+
+define i1 @ule_or_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_or_min(
+; CHECK-NEXT: [[CMP:%.*]] = icmp ule i8* [[X:%.*]], [[Y:%.*]]
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %cmp = icmp ule i8* %x, %y
+ %cmpeq = icmp eq i8* %x, null
+ %r = or i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ule_or_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_or_min_commute(
+; CHECK-NEXT: [[CMP:%.*]] = icmp ule i8* [[X:%.*]], [[Y:%.*]]
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %cmp = icmp ule i8* %x, %y
+ %cmpeq = icmp eq i8* %x, null
+ %r = or i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+define i1 @ule_swap_or_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_swap_or_min(
+; CHECK-NEXT: [[CMP:%.*]] = icmp uge i8* [[Y:%.*]], [[X:%.*]]
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %cmp = icmp uge i8* %y, %x
+ %cmpeq = icmp eq i8* %x, null
+ %r = or i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ule_swap_or_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ule_swap_or_min_commute(
+; CHECK-NEXT: [[CMP:%.*]] = icmp uge i8* [[Y:%.*]], [[X:%.*]]
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %cmp = icmp uge i8* %y, %x
+ %cmpeq = icmp eq i8* %x, null
+ %r = or i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;
+; (X != null) && (X > Y) --> X > Y
+;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+
+define i1 @ugt_and_not_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_and_not_min(
+; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i8* [[X:%.*]], [[Y:%.*]]
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %cmp = icmp ugt i8* %x, %y
+ %cmpeq = icmp ne i8* %x, null
+ %r = and i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ugt_and_not_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_and_not_min_commute(
+; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i8* [[X:%.*]], [[Y:%.*]]
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %cmp = icmp ugt i8* %x, %y
+ %cmpeq = icmp ne i8* %x, null
+ %r = and i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+define i1 @ugt_swap_and_not_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_swap_and_not_min(
+; CHECK-NEXT: [[CMP:%.*]] = icmp ult i8* [[Y:%.*]], [[X:%.*]]
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %cmp = icmp ult i8* %y, %x
+ %cmpeq = icmp ne i8* %x, null
+ %r = and i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ugt_swap_and_not_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_swap_and_not_min_commute(
+; CHECK-NEXT: [[CMP:%.*]] = icmp ult i8* [[Y:%.*]], [[X:%.*]]
+; CHECK-NEXT: ret i1 [[CMP]]
+;
+ %cmp = icmp ult i8* %y, %x
+ %cmpeq = icmp ne i8* %x, null
+ %r = and i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;
+; (X != null) || (X > Y) --> X != null
+;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+
+define i1 @ugt_or_not_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_or_not_min(
+; CHECK-NEXT: [[CMPEQ:%.*]] = icmp ne i8* [[X:%.*]], null
+; CHECK-NEXT: ret i1 [[CMPEQ]]
+;
+ %cmp = icmp ugt i8* %x, %y
+ %cmpeq = icmp ne i8* %x, null
+ %r = or i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ugt_or_not_min_commute(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_or_not_min_commute(
+; CHECK-NEXT: [[CMPEQ:%.*]] = icmp ne i8* [[X:%.*]], null
+; CHECK-NEXT: ret i1 [[CMPEQ]]
+;
+ %cmp = icmp ugt i8* %x, %y
+ %cmpeq = icmp ne i8* %x, null
+ %r = or i1 %cmpeq, %cmp
+ ret i1 %r
+}
+
+define i1 @ugt_swap_or_not_min(i8* %x, i8* %y) {
+; CHECK-LABEL: @ugt_swap_or_not_min(
+; CHECK-NEXT: [[CMPEQ:%.*]] = icmp ne i8* [[X:%.*]], null
+; CHECK-NEXT: ret i1 [[CMPEQ]]
+;
+ %cmp = icmp ult i8* %y, %x
+ %cmpeq = icmp ne i8* %x, null
+ %r = or i1 %cmp, %cmpeq
+ ret i1 %r
+}
+
+define i1 @ugt_swap_or_not_min_commute(i823* %x, i823* %y) {
+; CHECK-LABEL: @ugt_swap_or_not_min_commute(
+; CHECK-NEXT: [[CMPEQ:%.*]] = icmp ne i823* [[X:%.*]], null
+; CHECK-NEXT: ret i1 [[CMPEQ]]
+;
+ %cmp = icmp ult i823* %y, %x
+ %cmpeq = icmp ne i823* %x, null
+ %r = or i1 %cmpeq, %cmp
+ ret i1 %r
+}
More information about the llvm-commits
mailing list