[PATCH] D74484: [AggressiveInstCombine] Add support for ICmp instr that feeds a select intsr's condition operand.

[Ayman Musa via Phabricator via llvm-commits]

aymanmus marked 2 inline comments as done.
aymanmus added inline comments.


================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/TruncInstCombine.cpp:59
+  if (VT->isVectorTy()) {
+    for (unsigned i = 0; i < VT->getVectorNumElements(); i++) {
+      unsigned MinCurr =
----------------
ctetreau wrote:
> getVectorNumElements is going away soon. Please do the cast.
> 
> See: D77278
> 
> Also, is VT guaranteed to not be a scalable vector?
No, unfortunately I didn't take that into account.
How do you suggest that I deal with that?
How do scalable vectors of constants are represented?
Is:

```
if (auto *VT = dyn_cast<VectorType>(C->getType())) {
  for (unsigned i = 0; i < VT->getNumElements(); i++) {
```
a correct approach to such case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74484/new/

https://reviews.llvm.org/D74484