[PATCH] D78425: [ValueLattice] Add move constructor

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 19 02:07:11 PDT 2020


nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: include/llvm/Analysis/ValueLattice.h:145
+      break;
+    }
+    Other.Tag = unknown;
----------------
A better implementation of this would be:

    memcpy(this, &Other, sizeof(ValueLatticeElement));
    Other.Tag = unknown;

I'm not sure though whether this is legal C++ or not :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78425/new/

https://reviews.llvm.org/D78425





More information about the llvm-commits mailing list