[PATCH] D77152: [SelectionDAG] Better legalization for FSHL and FSHR

Sat Apr 18 12:22:29 PDT 2020

nikic added a comment.

In D77152#1984111 <https://reviews.llvm.org/D77152#1984111>, @foad wrote:

> In D77152#1984078 <https://reviews.llvm.org/D77152#1984078>, @RKSimon wrote:
>
> > @foad Any progress on fixing the crashes?
>
>
> Short answer: no not yet.
>
> I haven't thought of any clever way to implement ExpandIntegerResult for funnel shifts, so I just want to lower them and run ExpandIntegerResult on the lowered code instead. But I'm not sure how to implement that.

I believe this should be possible by calling `ReplaceValueWith` on the `expandFunnelShift` result (and returning an empty SDValue).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77152/new/

https://reviews.llvm.org/D77152