[PATCH] D78430: [InstSimplify] fold and/or of compares with equality to min/max constant

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 18 10:45:55 PDT 2020


aqjune added a comment.

In terms of correctness, this looks good to me.



================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:1486
-  if (UnsignedPred == ICmpInst::ICMP_ULT && EqPred == ICmpInst::ICMP_NE)
-    return IsAnd ? UnsignedICmp : ZeroICmp;
-
----------------
Is simplification on pointer comparisons still alive after this is removed? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78430/new/

https://reviews.llvm.org/D78430





More information about the llvm-commits mailing list