[PATCH] D78414: [llvm][NFC][CallSite] Remove CallSite from ProfileSummary
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 18 10:13:44 PDT 2020
dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/unittests/Analysis/ProfileSummaryInfoTest.cpp:230
- CallSite CS1(BB1->getFirstNonPHI());
+ CallBase &CS1 = *cast<CallBase>(BB1->getFirstNonPHI());
auto *CI2 = BB2->getFirstNonPHI();
----------------
I think I'd tend to deref first, then cast (the earlier the constraint is applied the better/tools can diagnose the problem closer to the source), but don't mind either way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78414/new/
https://reviews.llvm.org/D78414
More information about the llvm-commits
mailing list