[PATCH] D78326: [PredicateInfo] Factor out PredicateInfoBuilder (NFC)

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! As noted I think it would be slightly better to keep passing the OpsToRename explicitly, but I don't feel too strongly about that



================
Comment at: lib/Transforms/Utils/PredicateInfo.cpp:493
   // as assume statements.
-  SmallVector<Value *, 8> OpsToRename;
   for (auto DTN : depth_first(DT.getRootNode())) {
----------------
I think it would be slightly better to keep passing OpsToRename to various places, as it makes things a bit more explicit; that's the main list op operations to rename.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78326/new/

https://reviews.llvm.org/D78326