[PATCH] D78298: [LV] Invalidate cost model decisions along with interleave groups.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 18 03:13:22 PDT 2020
fhahn marked an inline comment as done.
fhahn added inline comments.
================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:1256
RequiresScalarEpilogue = false;
+ assert(!DelSet.empty() && "At least one group must be invalidated, as a "
+ "scalar epilogue was required");
----------------
Ayal wrote:
> Right, very good.
> Better place the assert immediately after the loop that fills DelSet.
>
> Independent fix: would be better to loop over InterleaveGroups rather than InterleaveGroupMap in order to fill DelSet; which could then be a SmallVector; w/o the need for the "Avoid releasing a Group twice" comment.
> Independent fix: would be better to loop over InterleaveGroups rather than InterleaveGroupMap in order to fill DelSet; which could then be a SmallVector; w/o the need for the "Avoid releasing a Group twice" comment.
I don't think we actually need an extra set/vector. Instead we should be able to just use an early_inc_range, which allows removing the current element as well: D78420
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78298/new/
https://reviews.llvm.org/D78298
More information about the llvm-commits
mailing list