[PATCH] D78397: [mlir][Transforms] Add pass to perform sparse conditional constant propagation

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 22:34:27 PDT 2020


bondhugula added a comment.

In D78397#1989834 <https://reviews.llvm.org/D78397#1989834>, @rriddle wrote:

> Thanks for the review Uday!
>
> I added the test case as `simple_loop_inner_control_flow`, let me know if that is what you had in mind or if there are any other tests you'd like to see.


The test case looks good - thanks. A round of mostly superficial comments. Btw, why is the build failing? I can't tell by chasing the links here:
https://reviews.llvm.org/harbormaster/build/61458/ and the status here is fine as well: https://buildkite.com/mlir/mlir-core
(This is for my future reference as well.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78397/new/

https://reviews.llvm.org/D78397





More information about the llvm-commits mailing list